fix(engine_twig_php): Pseudo patterns Twig PHP#1046
Merged
sghoweri merged 2 commits intopattern-lab:devfrom Oct 12, 2019
Merged
fix(engine_twig_php): Pseudo patterns Twig PHP#1046sghoweri merged 2 commits intopattern-lab:devfrom
sghoweri merged 2 commits intopattern-lab:devfrom
Conversation
Fixes issue where Twig PHP isn't rendering pseudo patterns correctly. Closes issue pattern-lab#1045
Member
|
I dont have the bandwidth to check out these Twig PRs, can someone else please review? |
Contributor
✋ I got this - no worries @bmuenzenmeyer! |
sghoweri
added
bug 🐛
twig renderer
Contributor
Author
|
🎉 Thanks @sghoweri ! |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…o-twigphp fix(engine_twig_php): Pseudo patterns Twig PHP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where Twig PHP isn't rendering pseudo patterns correctly.
Twig PHP rendered needs a path to the twig file in order to render it. For pseudo patterns this path points to a json file. Twig doesn't render it because it isn't a twig file.
This adds a check for pseudo pattern first and if it is a pseudo pattern use the
relPathfrom the base pattern instead. This means that the path to00-homepage~emergency.jsonwill be changed to00-homepage.twigand rendered with the data available in00-homepage~emergency.json.Closes issue #1045
Summary of changes: